Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1637413003: Stop using Isolate::GetCurrent() in inspector/v8 (Closed)

Created:
4 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using Isolate::GetCurrent() in inspector/v8 R=pfeldman@chromium.org BUG=580337 Committed: https://crrev.com/f94632ff7ff3b530fb19ce80ad91f17d2e91fc67 Cr-Commit-Position: refs/heads/master@{#371813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jochen (gone - plz use gerrit)
4 years, 11 months ago (2016-01-27 08:12:24 UTC) #1
pfeldman
lgtm
4 years, 11 months ago (2016-01-27 16:59:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637413003/1
4 years, 11 months ago (2016-01-27 17:26:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 17:35:37 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 17:37:49 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f94632ff7ff3b530fb19ce80ad91f17d2e91fc67
Cr-Commit-Position: refs/heads/master@{#371813}

Powered by Google App Engine
This is Rietveld 408576698