tools/dom/templates/html/impl/impl_SVGSVGElement.darttemplate - Issue 16374007: First rev of Safe DOM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/dom/templates/html/impl/impl_SVGSVGElement.darttemplate

Issue 16374007: First rev of Safe DOM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixing up recent test additions. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 part of $LIBRARYNAME;	5 part of $LIBRARYNAME;

6	6

7 $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {	7 $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

8 factory $CLASSNAME() => _$(CLASSNAME)FactoryProvider.createSvgSvgElement();	8 factory $CLASSNAME() {

	9 final el = new SvgElement.tag("svg");

	10 // The SVG spec requires the version attribute to match the spec version
	Jennifer Messerly 2013/08/17 06:07:07 curious why we need to do this? why doesn't DOM do curious why we need to do this? why doesn't DOM do it for us? blois 2013/08/19 22:02:09 Not sure- this code was just moved from the factor Show quoted text On 2013/08/17 06:07:07, John Messerly wrote: > curious why we need to do this? why doesn't DOM do it for us? Not sure- this code was just moved from the factory to here, so it's not new code.
	11 el.attributes['version'] = "1.1";

	12 return el;

	13 }

9	14

10 $!MEMBERS	15 $!MEMBERS

11 }	16 }

OLD	NEW