Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1637313002: Revert of Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes (Closed)

Created:
4 years, 11 months ago by pdr.
Modified:
4 years, 11 months ago
Reviewers:
tapted, ccameron
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes (patchset #2 id:20001 of https://codereview.chromium.org/1626163002/ ) Reason for revert: Broke compile: ../../ui/accelerated_widget_mac/display_link_mac.cc:94:69: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull] CVDisplayLinkSetOutputCallback(display_link_, nullptr, nullptr); ~~~~~~~ ^ Original issue's description: > Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes > > The CVDisplayLink is tied to a ScopedTypeRef data member of DisplayLinkMac. > However, there may be other references. Since there's no guarantee that > ~DisplayLinkMac() will invoke the last CVDisplayLinkRelease(..) and clear > the callback automatically, clear it explicitly in ~DisplayLinkMac. > > BUG=564780 > > Committed: https://crrev.com/2286ddf0119516f7a93feaff4f8ce2edff8c4543 > Cr-Commit-Position: refs/heads/master@{#371648} TBR=ccameron@chromium.org,tapted@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=564780 Committed: https://crrev.com/40b4841e82e2a559ffa94173d83e95ea3a64e146 Cr-Commit-Position: refs/heads/master@{#371724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ui/accelerated_widget_mac/display_link_mac.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
pdr.
Created Revert of Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes
4 years, 11 months ago (2016-01-27 04:30:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637313002/1
4 years, 11 months ago (2016-01-27 04:30:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637313002/1
4 years, 11 months ago (2016-01-27 04:32:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 04:36:03 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 04:37:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40b4841e82e2a559ffa94173d83e95ea3a64e146
Cr-Commit-Position: refs/heads/master@{#371724}

Powered by Google App Engine
This is Rietveld 408576698