Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: tools/telemetry/telemetry/page/page_measurement_unittest_base.py

Issue 16373012: [telemetry] Simplify the way PageRunner is called. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add DidStartHTTPServer() and re-add WillRunPageSet() Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_measurement_unittest_base.py
diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest_base.py b/tools/telemetry/telemetry/page/page_measurement_unittest_base.py
index 4fb1bd3b35ce480be70c95919733a49c4918b8a1..bf882239a0a84f4efa71db0fa361ff390cee4973 100644
--- a/tools/telemetry/telemetry/page/page_measurement_unittest_base.py
+++ b/tools/telemetry/telemetry/page/page_measurement_unittest_base.py
@@ -4,10 +4,8 @@
import os
import unittest
-from telemetry.core import browser_finder
from telemetry.page import page_runner
from telemetry.page import page as page_module
-from telemetry.page import page_measurement_results
from telemetry.page import page_set
from telemetry.unittest import options_for_unittests
@@ -41,9 +39,7 @@ class PageMeasurementUnitTestBase(unittest.TestCase):
setattr(options, k, v)
measurement.CustomizeBrowserOptions(options)
- possible_browser = browser_finder.FindBrowser(options)
-
- results = page_measurement_results.PageMeasurementResults()
- with page_runner.PageRunner(ps) as runner:
- runner.Run(options, possible_browser, measurement, results)
- return results
+ options.output_file = None
+ options.output_format = 'none'
+ options.output_trace_tag = None
+ return page_runner.Run(measurement, ps, options)
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_runner.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698