tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py - Issue 16373012: [telemetry] Simplify the way PageRunner is called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py

Issue 16373012: [telemetry] Simplify the way PageRunner is called. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add DidStartHTTPServer() and re-add WillRunPageSet() Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/csv_page_measurement_results.py ('k') | tools/telemetry/telemetry/page/page_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py

diff --git a/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py

index f4716e9e372d42c7a6599fc4c9b9171563276b32..b9e096f6cf97c67db781365307d1873c9a3824df 100644

--- a/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py

+++ b/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py

@@ -47,8 +47,7 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):

return rows[1:]

def test_with_output_after_every_page(self):

- results = NonPrintingCsvPageMeasurementResults(

- csv.writer(self._output), True)

+ results = NonPrintingCsvPageMeasurementResults(self._output, True)

results.WillMeasurePage(self._page_set[0])

results.Add('foo', 'seconds', 3)

results.DidMeasurePage()

@@ -70,8 +69,7 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):

[self._page_set[1].url, '4'])

def test_with_output_after_every_page_and_inconsistency(self):

- results = NonPrintingCsvPageMeasurementResults(

- csv.writer(self._output), True)

+ results = NonPrintingCsvPageMeasurementResults(self._output, True)

results.WillMeasurePage(self._page_set[0])

results.Add('foo', 'seconds', 3)

results.DidMeasurePage()

@@ -85,8 +83,7 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):

lambda: results.DidMeasurePage()) # pylint: disable=W0108

def test_with_output_at_print_summary_time(self):

- results = NonPrintingCsvPageMeasurementResults(csv.writer(self._output),

- False)

+ results = NonPrintingCsvPageMeasurementResults(self._output, False)

results.WillMeasurePage(self._page_set[0])

results.Add('foo', 'seconds', 3)

results.DidMeasurePage()

@@ -106,8 +103,7 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):

[self._page_set[1].url, '4', '-']])

def test_histogram(self):

- results = NonPrintingCsvPageMeasurementResults(csv.writer(self._output),

- False)

+ results = NonPrintingCsvPageMeasurementResults(self._output, False)

results.WillMeasurePage(self._page_set[0])

results.Add('a', '',

'{"buckets": [{"low": 1, "high": 2, "count": 1}]}',