Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: tools/telemetry/telemetry/core/browser.py

Issue 16373012: [telemetry] Simplify the way PageRunner is called. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add DidStartHTTPServer() and re-add WillRunPageSet() Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/browser.py
diff --git a/tools/telemetry/telemetry/core/browser.py b/tools/telemetry/telemetry/core/browser.py
index 09d37445c306b8f2128c9a7149634ea71b078246..daabd1be17400e1a8f4e7a8ad529fa6637cd557e 100644
--- a/tools/telemetry/telemetry/core/browser.py
+++ b/tools/telemetry/telemetry/core/browser.py
@@ -242,23 +242,26 @@ class Browser(object):
return self._http_server
def SetHTTPServerDirectories(self, paths):
+ """Returns True if the HTTP server was started, False otherwise."""
if not isinstance(paths, list):
paths = [paths]
paths = [os.path.abspath(p) for p in paths]
if paths and self._http_server and self._http_server.paths == paths:
- return
+ return False
if self._http_server:
self._http_server.Close()
self._http_server = None
if not paths:
- return
+ return False
self._http_server = temporary_http_server.TemporaryHTTPServer(
self._browser_backend, paths)
+ return True
+
def SetReplayArchivePath(self, archive_path, append_to_existing_wpr=False):
if self._wpr_server:
self._wpr_server.Close()
« no previous file with comments | « tools/perf/perf_tools/page_cycler.py ('k') | tools/telemetry/telemetry/page/csv_page_measurement_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698