Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1637293002: Reuse GLFenceNV when an existing CommandsCompletedQuery is reused (Closed)

Created:
4 years, 10 months ago by stanisc
Modified:
4 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reuse GLFenceNV when an existing CommandsCompletedQuery is reused This is a first part of the fix for 573120. When Begin/End are called again for a completed query that already has an instance of GLFenceNV, the existing GLFenceNV instance is reused rather than creating a new one. For each frame that saves one call to glGenFencesNV and one call to glDeleteFencesNV . My estimation is that that saves about 0.2 Wt when playing 1080p @ 60Hz h.264 content. The second part of the fix will add reusing instances of CommandsCompletedQuery. BUG=573120 Committed: https://crrev.com/1f3c24312efb7d76ccb331f170aa0941e6fdfda9 Cr-Commit-Position: refs/heads/master@{#371898}

Patch Set 1 #

Patch Set 2 : Moved ResetSupported check into a separate function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M gpu/command_buffer/service/gpu_scheduler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M ui/gl/gl_fence.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/gl/gl_fence.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ui/gl/gl_fence_nv.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_fence_nv.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stanisc
kbr@: Please review changes in ui/gl. jbaman@: Please review the rest.
4 years, 10 months ago (2016-01-27 19:40:19 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
4 years, 10 months ago (2016-01-27 20:02:33 UTC) #6
jbauman
lgtm
4 years, 10 months ago (2016-01-27 20:09:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637293002/20001
4 years, 10 months ago (2016-01-27 22:22:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-27 22:29:49 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 22:31:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f3c24312efb7d76ccb331f170aa0941e6fdfda9
Cr-Commit-Position: refs/heads/master@{#371898}

Powered by Google App Engine
This is Rietveld 408576698