PageRule should not serialize @page in selectorText

third_party/WebKit/Source/core/css/CSSPageRule.cpp

Index: third_party/WebKit/Source/core/css/CSSPageRule.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSPageRule.cpp b/third_party/WebKit/Source/core/css/CSSPageRule.cpp
index bee62d6d835914063f7707246220d33583963272..baa65e82bb150ee350fcc11797a7ccfdd3cf78ce 100644
--- a/third_party/WebKit/Source/core/css/CSSPageRule.cpp
+++ b/third_party/WebKit/Source/core/css/CSSPageRule.cpp
@@ -55,14 +55,11 @@ CSSStyleDeclaration* CSSPageRule::style() const
 String CSSPageRule::selectorText() const
 {
     StringBuilder text;
-    text.appendLiteral("@page");
     const CSSSelector* selector = m_pageRule->selector();
     if (selector) {
         String pageSpecification = selector->selectorText();
-        if (!pageSpecification.isEmpty() && pageSpecification != starAtom) {
-            text.append(' ');
+        if (!pageSpecification.isEmpty() && pageSpecification != starAtom)

[rune, 2016/01/28 18:15:47]

starAtom? That shouldn't be allowed in @page selectors?

[rwlbuis, 2016/01/28 22:27:50]

I removed it. Must be ancient code!

             text.append(pageSpecification);
-        }
     }
     return text.toString();
 }
@@ -82,6 +79,7 @@ void CSSPageRule::setSelectorText(const String& selectorText)
 String CSSPageRule::cssText() const
 {
     StringBuilder result;
+    result.appendLiteral("@page ");
     result.append(selectorText());
     result.appendLiteral(" { ");

[rune, 2016/01/28 18:15:47]

If selectorText() is empty, this results in a double space in the serialization.

[rwlbuis, 2016/01/28 22:27:50]

Done.

     String decls = m_pageRule->properties().asText();