Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: third_party/WebKit/Source/core/css/CSSPageRule.cpp

Issue 1637273003: PageRule should not serialize @page in selectorText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win build problem Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSPageRule.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSPageRule.cpp b/third_party/WebKit/Source/core/css/CSSPageRule.cpp
index bee62d6d835914063f7707246220d33583963272..e9e3898b1bb19011f58538ca83427375132ec27e 100644
--- a/third_party/WebKit/Source/core/css/CSSPageRule.cpp
+++ b/third_party/WebKit/Source/core/css/CSSPageRule.cpp
@@ -55,14 +55,11 @@ CSSStyleDeclaration* CSSPageRule::style() const
String CSSPageRule::selectorText() const
{
StringBuilder text;
- text.appendLiteral("@page");
const CSSSelector* selector = m_pageRule->selector();
if (selector) {
String pageSpecification = selector->selectorText();
- if (!pageSpecification.isEmpty() && pageSpecification != starAtom) {
- text.append(' ');
+ if (!pageSpecification.isEmpty())
text.append(pageSpecification);
- }
}
return text.toString();
}
@@ -82,8 +79,12 @@ void CSSPageRule::setSelectorText(const String& selectorText)
String CSSPageRule::cssText() const
{
StringBuilder result;
- result.append(selectorText());
- result.appendLiteral(" { ");
+ result.appendLiteral("@page ");
+ String pageSelectors = selectorText();
+ result.append(pageSelectors);
+ if (!pageSelectors.isEmpty())
+ result.appendLiteral(" ");
+ result.appendLiteral("{ ");
String decls = m_pageRule->properties().asText();
result.append(decls);
if (!decls.isEmpty())

Powered by Google App Engine
This is Rietveld 408576698