Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 163723003: Cherry pick r516 from upstream protobuf (Closed)

Created:
6 years, 10 months ago by sdefresne
Modified:
6 years, 10 months ago
CC:
chromium-reviews, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cherry pick r516 from upstream protobuf Fix compilation for arm64. TBR=cpu@chromium.org R=mark@chromium.org BUG=314720 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251345

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/protobuf/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/platform_macros.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sdefresne
PTAL
6 years, 10 months ago (2014-02-13 19:29:56 UTC) #1
sdefresne
-blundell, +mark: Could you please take a look (I see that you've sometimes reviewed changes ...
6 years, 10 months ago (2014-02-14 14:07:26 UTC) #2
Mark Mentovai
LGTM
6 years, 10 months ago (2014-02-14 14:15:19 UTC) #3
blundell
Out of curiosity, do you know why we don't seem to roll protobuf?
6 years, 10 months ago (2014-02-14 14:16:26 UTC) #4
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 10 months ago (2014-02-14 14:30:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/163723003/1
6 years, 10 months ago (2014-02-14 14:30:57 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 14:30:59 UTC) #7
commit-bot: I haz the power
Failed to apply patch for third_party/protobuf/README.chromium: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-14 14:31:00 UTC) #8
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 10 months ago (2014-02-14 14:34:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/163723003/150001
6 years, 10 months ago (2014-02-14 14:34:26 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 16:28:46 UTC) #11
Message was sent while issue was closed.
Change committed as 251345

Powered by Google App Engine
This is Rietveld 408576698