chrome/browser/ui/views/dropdown_bar_host.cc - Issue 1637203002: [MD] Don't use new OTR native-theming when using a custom browser theme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/dropdown_bar_host.cc

Issue 1637203002: [MD] Don't use new OTR native-theming when using a custom browser theme. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: todo done Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc ('k') | chrome/browser/ui/views/frame/browser_frame.h » ('j') | chrome/browser/ui/views/theme_copying_widget.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/dropdown_bar_host.cc

diff --git a/chrome/browser/ui/views/dropdown_bar_host.cc b/chrome/browser/ui/views/dropdown_bar_host.cc

index e2c408873f780c1be6d672bb84f0c2fc0ba01f5d..6cbc0542c1bba986892f1cff889021cacc27bf33 100644

--- a/chrome/browser/ui/views/dropdown_bar_host.cc

+++ b/chrome/browser/ui/views/dropdown_bar_host.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/ui/views/dropdown_bar_host_delegate.h"

#include "chrome/browser/ui/views/dropdown_bar_view.h"

#include "chrome/browser/ui/views/frame/browser_view.h"

+#include "chrome/browser/ui/views/theme_copying_widget.h"

#include "ui/events/keycodes/keyboard_codes.h"

#include "ui/gfx/animation/slide_animation.h"

#include "ui/gfx/scrollbar_size.h"

@@ -48,7 +49,7 @@ void DropdownBarHost::Init(views::View* host_view,

delegate_ = delegate;

// Initialize the host.

- host_.reset(new views::Widget);

+ host_.reset(new ThemeCopyingWidget(browser_view_->GetWidget()));

views::Widget::InitParams params(views::Widget::InitParams::TYPE_CONTROL);

params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

params.parent = browser_view_->GetWidget()->GetNativeView();