[MD] Don't use new OTR native-theming when using a custom browser theme.

[MD] Don't use new OTR native-theming when using a custom browser theme.

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1

Committed: https://crrev.com/426c9fcce7a81e6e20dac1d4b2cc6fcda7aab510
Cr-Commit-Position: refs/heads/master@{#371990}

[Evan Stade, 2016-01-27 00:44:18]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-01-27 00:44:18]

before, we decided to use an InitParams native theme because I didn't think a
widget's NativeTheme could change. Now I've discovered a case where it must
change: incognito window is open and you switch between classic and custom or
gtk theme.

https://codereview.chromium.org/1637203002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/dropdown_bar_host.cc (right):

https://codereview.chromium.org/1637203002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/dropdown_bar_host.cc:22: // TODO(estade): move this to
its own file and reuse for
I would complete this TODO before landing, but only if this general approach
lgty

[Evan Stade, 2016-01-27 00:44:37]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 00:45:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1637203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1637203002/20001

[commit-bot: I haz the power, 2016-01-27 01:30:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:30:36]

Dry run: This issue passed the CQ dry run.

[sky, 2016-01-27 03:07:31]

LGTM

https://codereview.chromium.org/1637203002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_root_view.cc (right):

https://codereview.chromium.org/1637203002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_root_view.cc:25: #if defined(OS_LINUX)
Do you really need these includes here?

[Evan Stade, 2016-01-28 00:08:44]

https://codereview.chromium.org/1637203002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_root_view.cc (right):

https://codereview.chromium.org/1637203002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_root_view.cc:25: #if defined(OS_LINUX)
On 2016/01/27 03:07:31, sky wrote:
> Do you really need these includes here?

no, this is left over from a previous iteration of the patch. Removed.

[Evan Stade, 2016-01-28 00:09:11]

also, did the TODO, ptal

[sky, 2016-01-28 00:58:18]

LGTM

https://codereview.chromium.org/1637203002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/theme_copying_widget.h (right):

https://codereview.chromium.org/1637203002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/theme_copying_widget.h:20: // The widget we'll copy our
theme from. It's assumed to outlive |this|.
nit: I would move the lifetime comment to the class description and/or
constructor. It's easy to miss it here.

[Evan Stade, 2016-01-28 01:47:05]

https://codereview.chromium.org/1637203002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/theme_copying_widget.h (right):

https://codereview.chromium.org/1637203002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/theme_copying_widget.h:20: // The widget we'll copy our
theme from. It's assumed to outlive |this|.
On 2016/01/28 00:58:17, sky wrote:
> nit: I would move the lifetime comment to the class description and/or
> constructor. It's easy to miss it here.

Done.

[Evan Stade, 2016-01-28 02:14:57]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-01-28 02:14:57]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1637203002/#ps60001
(title: "move lifetime comment")

[Evan Stade, 2016-01-28 02:15:16]

Description was changed from

==========
[MD] Don't use new OTR native-theming when using a custom browser theme.

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=none
depends on http://crrev.com/1638063003#ps1
==========

to

==========
[MD] Don't use new OTR native-theming when using a custom browser theme.

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1
==========

[Evan Stade, 2016-01-28 02:15:21]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-01-28 02:15:25]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-01-28 02:19:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1637203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1637203002/60001

[commit-bot: I haz the power, 2016-01-28 03:24:47]

Description was changed from

==========
[MD] Don't use new OTR native-theming when using a custom browser theme.

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1
==========

to

==========
[MD] Don't use new OTR native-theming when using a custom browser theme.

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1
==========

[commit-bot: I haz the power, 2016-01-28 03:24:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 03:25:47]

Description was changed from

==========
[MD] Don't use new OTR native-theming when using a custom browser theme.

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1
==========

to

==========
[MD] Don't use new OTR native-theming when using a custom browser theme.

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1

Committed: https://crrev.com/426c9fcce7a81e6e20dac1d4b2cc6fcda7aab510
Cr-Commit-Position: refs/heads/master@{#371990}
==========

[commit-bot: I haz the power, 2016-01-28 03:25:47]

Patchset 4 (id:??) landed as
https://crrev.com/426c9fcce7a81e6e20dac1d4b2cc6fcda7aab510
Cr-Commit-Position: refs/heads/master@{#371990}