Subzero. ARM32. Vector lowering. And.

src/IceInstARM32.cpp

Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index 03b65dd79cd2b9a2a71ea6c6e07b58abbc7f0bb5..ec5c7a13db45b1c6f1deb94ca59c338a5f162db1 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -616,6 +616,11 @@ template <> void InstARM32Vadd::emitIAS(const Cfg *Func) const {
   }
 }
 
+template <> void InstARM32Vand::emitIAS(const Cfg *Func) const {
+  // TODO(kschimpf) add support for these instructions

[Eric Holk, 2016/01/26 23:24:23]

Is it okay to put TODOs for other people?

[John, 2016/01/27 15:22:20]

usually the person in

TODO(person)

should be the one that is likely to know more about the issue. So yes, this is
fine. :)

but please say TODO(person): (you forgot the ':' )

+  emitUsingTextFixup(Func);
+}
+
 template <> void InstARM32Vdiv::emitIAS(const Cfg *Func) const {
   auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
   const Variable *Dest = getDest();
@@ -1002,6 +1007,7 @@ template <> const char *InstARM32Sub::Opcode = "sub";
 template <> const char *InstARM32Udiv::Opcode = "udiv";
 // FP
 template <> const char *InstARM32Vadd::Opcode = "vadd";
+template <> const char *InstARM32Vand::Opcode = "vand";
 template <> const char *InstARM32Vdiv::Opcode = "vdiv";
 template <> const char *InstARM32Veor::Opcode = "veor";
 template <> const char *InstARM32Vmla::Opcode = "vmla";