Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2057)

Issue 1637163003: X87: [es6] Tail calls support. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Tail calls support. port 6131ab1edd6e78be01ac90b8f0b0f4f27f308071 (r33509) original commit message: This CL implements PrepareForTailCall() mentioned in ES6 spec for full codegen, Crankshaft and Turbofan. When debugger is active tail calls are disabled. Tail calling can be enabled by --harmony-tailcalls flag. BUG= Committed: https://crrev.com/66e2a786795859926e0ea3d23620e743a59fe88e Cr-Commit-Position: refs/heads/master@{#33549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -22 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x87/builtins-x87.cc View 6 chunks +141 lines, -6 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-27 02:13:52 UTC) #2
Igor Sheludko
lgtm
4 years, 11 months ago (2016-01-27 09:04:37 UTC) #3
Weiliang
lgtm
4 years, 11 months ago (2016-01-27 11:36:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637163003/1
4 years, 11 months ago (2016-01-27 12:29:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 12:59:56 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 13:00:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66e2a786795859926e0ea3d23620e743a59fe88e
Cr-Commit-Position: refs/heads/master@{#33549}

Powered by Google App Engine
This is Rietveld 408576698