third_party/WebKit/Source/core/paint/TableRowPainter.cpp - Issue 1637143002: Layers that have a backdrop-filter should paints contents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TableRowPainter.cpp

Issue 1637143002: Layers that have a backdrop-filter should paints contents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/BoxDecorationData.cpp ('K') | « third_party/WebKit/Source/core/paint/TableCellPainter.cpp ('k') | third_party/WebKit/Source/core/paint/TableSectionPainter.cpp » ('j') | third_party/WebKit/Source/core/paint/TableSectionPainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/TableRowPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/TableRowPainter.cpp b/third_party/WebKit/Source/core/paint/TableRowPainter.cpp

index b7c333e0b4a8f13c7777cdf8bc27d333803d3d09..cc7809a74e93013a20bf67742bf24de498ffe133 100644

--- a/third_party/WebKit/Source/core/paint/TableRowPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/TableRowPainter.cpp

@@ -23,7 +23,7 @@ void TableRowPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paint

return;

PaintInfo paintInfoForCells = paintInfo.forDescendants();

- bool shouldPaintRowBackground = shouldPaintSelfBlockBackground(paintInfo.phase) && m_layoutTableRow.hasBackground();

+ bool shouldPaintRowBackground = shouldPaintSelfBlockBackground(paintInfo.phase) && (m_layoutTableRow.hasBackground() || m_layoutTableRow.styleRef().hasBackdropFilter());

bool shouldPaintCells = paintInfo.phase != PaintPhaseSelfBlockBackgroundOnly;

for (LayoutTableCell* cell = m_layoutTableRow.firstCell(); cell; cell = cell->nextCell()) {

if (shouldPaintRowBackground)