Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1637113003: Add simplistic screenlock application. (Closed)

Created:
4 years, 11 months ago by Ben Goodger (Google)
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add simplistic screenlock application. Lock state is controlled by mash_shell, which will connect to the screenlock application to show a view. TBD: broadcasting lock state changes via a listener. TBD: a better mechanism for quitting an application. R=sky@chromium.org http://crbug.com/557398 Committed: https://crrev.com/1a26c8220ac6bd396bddb4585ff9e8e2de448df2 Cr-Commit-Position: refs/heads/master@{#371826}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -10 lines) Patch
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M mash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 5 chunks +9 lines, -4 lines 0 comments Download
A mash/screenlock/BUILD.gn View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A mash/screenlock/main.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A mash/screenlock/public/interfaces/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A mash/screenlock/public/interfaces/screenlock.mojom View 1 chunk +10 lines, -0 lines 0 comments Download
A mash/screenlock/screenlock.h View 1 chunk +57 lines, -0 lines 0 comments Download
A mash/screenlock/screenlock.cc View 1 chunk +119 lines, -0 lines 0 comments Download
M mash/shell/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A mash/shell/public/interfaces/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A mash/shell/public/interfaces/shell.mojom View 1 chunk +12 lines, -0 lines 0 comments Download
M mash/shell/shell_application_delegate.h View 4 chunks +19 lines, -1 line 0 comments Download
M mash/shell/shell_application_delegate.cc View 3 chunks +32 lines, -1 line 0 comments Download
M mash/wm/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/wm/screenlock_layout.h View 1 chunk +30 lines, -0 lines 0 comments Download
A mash/wm/screenlock_layout.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M mash/wm/window_manager_application.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Ben Goodger (Google)
4 years, 11 months ago (2016-01-26 22:01:12 UTC) #1
sky
LGTM
4 years, 11 months ago (2016-01-26 22:22:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637113003/1
4 years, 11 months ago (2016-01-26 22:51:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637113003/20001
4 years, 11 months ago (2016-01-26 22:57:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/41463) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-26 23:07:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637113003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637113003/40001
4 years, 11 months ago (2016-01-27 17:54:51 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-27 18:36:47 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 18:39:04 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a26c8220ac6bd396bddb4585ff9e8e2de448df2
Cr-Commit-Position: refs/heads/master@{#371826}

Powered by Google App Engine
This is Rietveld 408576698