Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 1637093002: Fix enable_cardboard/enable_cast for GN build of remoting/android. (Closed)

Created:
4 years, 11 months ago by Lambros
Modified:
4 years, 11 months ago
Reviewers:
Sergey Ulanov, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix enable_cardboard/enable_cast for GN build of remoting/android. This makes the settings into proper GN args that can be overridden. Also added "remoting" to their names since they are remoting-specific. Also fixed the Cardboard-enabled build (code was expecting '1'/'0' but GN was supplying 'true'/'false'). Committed: https://crrev.com/0e1b88f24b66c785568a065675d88d1e128ef99b Cr-Commit-Position: refs/heads/master@{#371602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M remoting/android/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M remoting/android/client_java_tmpl.gni View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_options.gni View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Lambros
4 years, 11 months ago (2016-01-26 19:20:56 UTC) #2
Sergey Ulanov
lgtm
4 years, 11 months ago (2016-01-26 19:37:57 UTC) #4
garykac
lgtm
4 years, 11 months ago (2016-01-26 20:04:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637093002/1
4 years, 11 months ago (2016-01-26 20:05:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/13128)
4 years, 11 months ago (2016-01-26 20:28:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637093002/1
4 years, 11 months ago (2016-01-26 21:05:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 21:35:55 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 21:38:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e1b88f24b66c785568a065675d88d1e128ef99b
Cr-Commit-Position: refs/heads/master@{#371602}

Powered by Google App Engine
This is Rietveld 408576698