Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1637083004: CC Animation: Remove meaningless method from WebLayer. (Closed)

Created:
4 years, 11 months ago by loyso (OOO)
Modified:
4 years, 11 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Remove meaningless method from WebLayer. We always create new animations with unique ids. So the removeAnimation(unique_id, target_property) call on adding a new animation is meaningless. This change allows us to forward declare WebCompositorAnimation class for WebLayer interface. BUG=577016 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/aa6dcbe9992ae5aa506bb0a69945acef8350078e Cr-Commit-Position: refs/heads/master@{#371788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M cc/animation/layer_animation_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M cc/blink/web_layer_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/layers/layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 3 chunks +1 line, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
loyso (OOO)
4 years, 11 months ago (2016-01-27 01:05:50 UTC) #7
aelias_OOO_until_Jul13
lgtm
4 years, 11 months ago (2016-01-27 01:42:05 UTC) #8
ajuma
lgtm
4 years, 11 months ago (2016-01-27 14:07:42 UTC) #9
Ian Vollick
On 2016/01/27 14:07:42, ajuma wrote: > lgtm lgtm.
4 years, 11 months ago (2016-01-27 15:04:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637083004/1
4 years, 11 months ago (2016-01-27 15:04:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 15:10:07 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 15:11:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa6dcbe9992ae5aa506bb0a69945acef8350078e
Cr-Commit-Position: refs/heads/master@{#371788}

Powered by Google App Engine
This is Rietveld 408576698