Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: Source/bindings/core/dart/DartUtilities.cpp

Issue 1637083003: Added issue on crashing Dartium 45 pausing and remove method not used. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/2454_1
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/dart/DartUtilities.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/dart/DartUtilities.cpp
diff --git a/Source/bindings/core/dart/DartUtilities.cpp b/Source/bindings/core/dart/DartUtilities.cpp
index a94f87714a0eaa055e05f6ab8cf348bf20ef2ae9..935303bc6ee3d021a8eb6a14d24c478bcd3d29e1 100644
--- a/Source/bindings/core/dart/DartUtilities.cpp
+++ b/Source/bindings/core/dart/DartUtilities.cpp
@@ -439,6 +439,9 @@ Dart_Handle DartUtilities::numberToDart(double value)
ScriptValue DartUtilities::dartToScriptValue(Dart_Handle object)
{
+ // TODO(terry): Added bug per JacobR - he thinks it would be better to use
+ // DartHandleProxy probably pressing pause crashes Dartium 45.
+ // See issue: https://github.com/dart-lang/sdk/issues/25589
Dart_Handle exception = 0;
ScriptState* v8ScriptState = currentDartScriptState()->v8ScriptState();
v8::Handle<v8::Value> value = V8Converter::toV8(object, exception);
@@ -1103,13 +1106,6 @@ DartScriptState* DartUtilities::currentDartScriptState()
return dartDOMData->rootScriptState();
}
-PassRefPtr<ScriptArguments> DartUtilities::createScriptArguments(Dart_Handle argument, Dart_Handle& exception)
-{
- Vector<ScriptValue> arguments;
- arguments.append(DartUtilities::dartToScriptValue(argument));
- return ScriptArguments::create(DartUtilities::currentDartScriptState()->v8ScriptState(), arguments);
-}
-
static PassRefPtr<ScriptCallStack> createScriptCallStackFromStackTrace(Dart_StackTrace stackTrace)
{
uintptr_t frameCount = 0;
« no previous file with comments | « Source/bindings/core/dart/DartUtilities.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698