Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: content/public/common/cdm_info.h

Issue 1637083002: Add CdmService to keep track of CDMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changes + file move Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_PUBLIC_COMMON_CDM_INFO_H_
6 #define CONTENT_PUBLIC_COMMON_CDM_INFO_H_
7
8 #include <string>
9 #include <vector>
10
11 #include "base/files/file_path.h"
12 #include "base/version.h"
13 #include "content/common/content_export.h"
14
15 namespace content {
16
17 // Represents a Content Decryption Module implementation and its capabilities.
18 struct CONTENT_EXPORT CdmInfo {
19 CdmInfo(const std::string& name,
20 const base::Version& version,
21 const base::FilePath& path,
22 const std::vector<std::string>& supported_codecs);
23 ~CdmInfo();
24
25 // Identifier for the CDM (e.g. Widevine).
xhwang 2016/03/26 07:46:34 nit: s/Identifier/Name?
jrummell 2016/03/29 23:48:45 Done.
26 std::string name;
xhwang 2016/03/26 07:46:34 Not for this CL. I wonder whether we should use en
jrummell 2016/03/29 23:48:45 Could be done, but then Cast would need to change
xhwang 2016/03/30 05:11:18 Can consolidate on "name" vs "type" (as in the fil
jrummell 2016/04/01 21:15:53 Switched to "type".
27
28 // Version of the CDM. May be empty if the version is not known.
29 base::Version version;
30
31 // Path to the library implementing the CDM. May be empty if the
32 // CDM is always available (e.g. Widevine on Android).
xhwang 2016/03/26 07:46:34 On Linux our WV CDM is also always available... It
jrummell 2016/03/29 23:48:45 Done.
33 base::FilePath path;
34
35 // List of codecs supported by the CDM (e.g. webm).
xhwang 2016/03/26 07:46:34 nit: "webm" is not a codec. You can use "vp8" as a
jrummell 2016/03/29 23:48:45 Done.
36 std::vector<std::string> supported_codecs;
xhwang 2016/03/26 07:46:34 We should probably use VideoCodec and AudioCodec h
37 };
38
39 } // namespace content
40
41 #endif // CONTENT_PUBLIC_COMMON_CDM_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698