Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1637063002: Add a fieldtrial testing config for Mach SharedMemory experiment. (Closed)

Created:
4 years, 11 months ago by erikchen
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a fieldtrial testing config for Mach SharedMemory experiment. Note that Mach shared memory is already turned on by default on trunk, so this has no effect. The main purpose of this CL is to disable a Finch warning. See https://critique.corp.google.com/#review/113054955 for more details. BUG=552422 Committed: https://crrev.com/63a9586b651d8f6580c3b36561aae27f925289fb Cr-Commit-Position: refs/heads/master@{#371557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
erikchen
asvitkine: Please review.
4 years, 11 months ago (2016-01-26 18:52:07 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 11 months ago (2016-01-26 18:55:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637063002/1
4 years, 11 months ago (2016-01-26 18:56:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 19:23:48 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 19:25:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63a9586b651d8f6580c3b36561aae27f925289fb
Cr-Commit-Position: refs/heads/master@{#371557}

Powered by Google App Engine
This is Rietveld 408576698