Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1637033002: Remove HTTP/2 status text from SpdyTestUtil. (Closed)

Created:
4 years, 11 months ago by Bence
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HTTP/2 status text from SpdyTestUtil. Remove status text "OK" from SpdyTestUtil::ConstructSpdyPush() and SpdyTestUtil::ConstructSpdyPushHeaders(), because HTTP/2 bans the use of status text. Update net_unittests. Committed: https://crrev.com/cdc749f3811c302a2ac6ac9095d4987f5c33e021 Cr-Commit-Position: refs/heads/master@{#371804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thanks.
4 years, 11 months ago (2016-01-26 17:03:30 UTC) #2
Ryan Hamilton
lgtm
4 years, 11 months ago (2016-01-26 20:22:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637033002/1
4 years, 11 months ago (2016-01-27 16:12:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 16:39:11 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 16:40:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdc749f3811c302a2ac6ac9095d4987f5c33e021
Cr-Commit-Position: refs/heads/master@{#371804}

Powered by Google App Engine
This is Rietveld 408576698