Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: trunk/src/content/browser/renderer_host/render_view_host_impl.cc

Issue 163703004: Revert 250823 "With --site-per-process, avoid a crash when a sub..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/render_view_host_impl.cc
===================================================================
--- trunk/src/content/browser/renderer_host/render_view_host_impl.cc (revision 251088)
+++ trunk/src/content/browser/renderer_host/render_view_host_impl.cc (working copy)
@@ -1431,9 +1431,11 @@
render_view_termination_status_ =
static_cast<base::TerminationStatus>(status);
- // Reset frame tree state associated with this process.
+ // Reset frame tree state.
+ // TODO(creis): Once subframes can be in different processes, we'll need to
+ // clear just the FrameTreeNodes affected by the crash (and their subtrees).
main_frame_id_ = -1;
- delegate_->GetFrameTree()->RenderProcessGone(this);
+ delegate_->GetFrameTree()->ResetForMainFrameSwap();
// Our base class RenderWidgetHost needs to reset some stuff.
RendererExited(render_view_termination_status_, exit_code);
« no previous file with comments | « trunk/src/content/browser/frame_host/frame_tree_node.cc ('k') | trunk/src/content/browser/site_per_process_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698