Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1637013002: Revert of Fix leaks in exensions_unittests after enabling Oilpan (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
CC:
bruening+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, glider+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix leaks in exensions_unittests after enabling Oilpan (patchset #1 id:1 of https://codereview.chromium.org/1632763003/ ) Reason for revert: This CL didn't fix the leak. Also per the discussion in https://codereview.chromium.org/1632763003/, suppressing the leak looks like a reasonable solution at the moment. So revert this CL. Original issue's description: > Fix leaks in exensions_unittests after enabling Oilpan > > This CL adds an Oilpan's GC before tearing down the extensions_unittests. > > BUG=581092 > > Committed: https://crrev.com/6ae6611de742bb291305a1df558e710213556fa4 > Cr-Commit-Position: refs/heads/master@{#371408} TBR=rockot@chromium.org,oilpan-reviews@chromium.org,oshima@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581092 Committed: https://crrev.com/88749be16db5fa1e8d7f8a56b215d0ccda4ef0ef Cr-Commit-Position: refs/heads/master@{#371502}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M extensions/renderer/module_system_test.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
haraken
Created Revert of Fix leaks in exensions_unittests after enabling Oilpan
4 years, 11 months ago (2016-01-26 12:57:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637013002/1
4 years, 11 months ago (2016-01-26 12:57:25 UTC) #2
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/memcheck/suppressions.txt: While running git apply --index -3 -p1; error: patch ...
4 years, 11 months ago (2016-01-26 12:57:57 UTC) #4
sof
lgtm
4 years, 11 months ago (2016-01-26 12:59:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637013002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637013002/70001
4 years, 11 months ago (2016-01-26 13:35:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 11 months ago (2016-01-26 13:36:22 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 13:38:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88749be16db5fa1e8d7f8a56b215d0ccda4ef0ef
Cr-Commit-Position: refs/heads/master@{#371502}

Powered by Google App Engine
This is Rietveld 408576698