Chromium Code Reviews
Help | Chromium Project | Sign in
(386)

Issue 1637013: Merge 44442 - If the server's CertificateRequest message contains an empty... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
wtc
CC:
chromium-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Merge part of 44442 -
If the server's CertificateRequest message contains an empty
certificate_authorities list, it means client certificates issued by
any CA are acceptable. NSS_CmpCertChainWCANames returns SECFailure
in that case, so we need to test for that case.

R=agl
BUG=16830
TEST=Visit a server that sends a CertificateRequest message with an
empty certificate_authorities list. The client certificate selection
dialog should pop up with all client certificates shown as eligible.
Review URL: http://codereview.chromium.org/1589034

TBR=wtc@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44589

Patch Set 1 #

Patch Set 2 : Keep only the client auth fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Lint Patch
M net/socket/ssl_client_socket_nss.cc View 1 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 1

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434