Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 16370007: stub webkit/child/ and webkitplatformsupport_child_impl for transition (Closed)

Created:
7 years, 6 months ago by scottmg
Modified:
7 years, 6 months ago
Reviewers:
jamesr, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, ananta
Visibility:
Public.

Description

stub webkit/child/ and webkitplatformsupport_child_impl for transition Do-nothing for in separating webkit/glue/webkitlatformsupport_impl. glue_child depends on glue for now of course. TBR=jamesr@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205859

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : remove unnecessary dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M content/child/webkitplatformsupport_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/child/webkit_child_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
A webkit/child/webkitplatformsupport_child_impl.h View 1 chunk +22 lines, -0 lines 0 comments Download
A webkit/child/webkitplatformsupport_child_impl.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
7 years, 6 months ago (2013-06-12 02:21:26 UTC) #1
jamesr
lgtm https://codereview.chromium.org/16370007/diff/6001/webkit/glue/webkit_glue.gypi File webkit/glue/webkit_glue.gypi (right): https://codereview.chromium.org/16370007/diff/6001/webkit/glue/webkit_glue.gypi#newcode65 webkit/glue/webkit_glue.gypi:65: 'dependencies': [ could we start minimal and add ...
7 years, 6 months ago (2013-06-12 03:56:44 UTC) #2
scottmg
https://codereview.chromium.org/16370007/diff/6001/webkit/glue/webkit_glue.gypi File webkit/glue/webkit_glue.gypi (right): https://codereview.chromium.org/16370007/diff/6001/webkit/glue/webkit_glue.gypi#newcode65 webkit/glue/webkit_glue.gypi:65: 'dependencies': [ On 2013/06/12 03:56:44, jamesr wrote: > could ...
7 years, 6 months ago (2013-06-12 04:09:54 UTC) #3
scottmg
tbr jam for file rename affecting content/child/
7 years, 6 months ago (2013-06-12 17:43:19 UTC) #4
scottmg
Committed patchset #2 manually as r205859 (presubmit successful).
7 years, 6 months ago (2013-06-12 17:44:28 UTC) #5
jam
7 years, 6 months ago (2013-06-12 17:45:52 UTC) #6
Message was sent while issue was closed.
lgtm for content

Powered by Google App Engine
This is Rietveld 408576698