chrome/browser/favicon/favicon_handler.cc - Issue 16370006: Make the favicons look visually the same after refreshing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.cc

Issue 16370006: Make the favicons look visually the same after refreshing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed avi@'s comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler.cc

diff --git a/chrome/browser/favicon/favicon_handler.cc b/chrome/browser/favicon/favicon_handler.cc

index 47717904c95f63739669dec5ea42ecc889316508..57887b705ddaa1f7374c3d1dbfd61932df703551 100644

--- a/chrome/browser/favicon/favicon_handler.cc

+++ b/chrome/browser/favicon/favicon_handler.cc

@@ -300,7 +300,10 @@ void FaviconHandler::UpdateFavicon(NavigationEntry* entry,

if (image.IsEmpty())

return;

- entry->GetFavicon().image = image;

+ gfx::Image image_with_adjusted_colorspace = image;

+ FaviconUtil::SetFaviconColorSpace(&image_with_adjusted_colorspace);

+ entry->GetFavicon().image = image_with_adjusted_colorspace;

delegate_->NotifyFaviconUpdated(icon_url_changed);

}