Issue 16370002: Add Extensions.BackgroundPageType histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16370002: Add Extensions.BackgroundPageType histogram. (Closed)

Created:
7 years, 6 months ago by Matt Perry

Modified:
7 years, 6 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add Extensions.BackgroundPageType histogram. Added to code in crrev.com/203879 . BUG=245033 R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204094

Patch Set 2 : better summary #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	tools/metrics/histograms/histograms.xml	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

LGTM with nit below. https://codereview.chromium.org/16370002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/16370002/diff/1/tools/metrics/histograms/histograms.xml#newcode1659 tools/metrics/histograms/histograms.xml:1659: <summary>The type (if any) of ...

7 years, 6 months ago (2013-06-04 23:53:58 UTC) #2

Matt Perry

https://codereview.chromium.org/16370002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/16370002/diff/1/tools/metrics/histograms/histograms.xml#newcode1659 tools/metrics/histograms/histograms.xml:1659: <summary>The type (if any) of background page the extension ...

7 years, 6 months ago (2013-06-05 00:04:22 UTC) #3

Matt Perry

7 years, 6 months ago (2013-06-05 00:06:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r204094 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16370002: Add Extensions.BackgroundPageType histogram. (Closed)

Description

Patch Set 1 #

Patch Set 2 : better summary #

Messages