Oilpan: LargeObjectPage should use HeapObjectHeader::payloadSize() instead of HeapObjectHeader::siz…

Oilpan: LargeObjectPage should use HeapObjectHeader::payloadSize() instead of HeapObjectHeader::size()

HeapObjectHeader::size() is a fast version of HeapObjectHeader::payloadSize() which works only
for headers in NormalHeapPages and FreeLists. LargeObjectPages must use HeapObjectHeader::payloadSize() instead.

BUG=581138
Committed: https://crrev.com/7e718004bcef5606f63211456a16cde149206525
Cr-Commit-Position: refs/heads/master@{#371483}

[haraken, 2016-01-26 06:26:28]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, sigbjornf@opera.com

[haraken, 2016-01-26 06:26:29]

PTAL

(I think we should rename the method to clarify the difference in a follow-up.)

[sof, 2016-01-26 06:31:49]

https://codereview.chromium.org/1636983002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right):

https://codereview.chromium.org/1636983002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/HeapPage.cpp:1515: liveSize +=
header->payloadSize();
Add a single binding size_t headerSize = header->payloadSize() above the if &
use it throughout?

[haraken, 2016-01-26 06:35:02]

On 2016/01/26 06:31:49, sof wrote:
>
https://codereview.chromium.org/1636983002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right):
> 
>
https://codereview.chromium.org/1636983002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/heap/HeapPage.cpp:1515: liveSize +=
> header->payloadSize();
> Add a single binding size_t headerSize = header->payloadSize() above the if &
> use it throughout?

Done.

[sof, 2016-01-26 06:36:23]

lgtm

[haraken, 2016-01-26 06:37:06]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-01-26 06:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636983002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636983002/20001

[commit-bot: I haz the power, 2016-01-26 09:48:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 09:49:57]

Description was changed from

==========
Oilpan: LargeObjectPage should use HeapObjectHeader::payloadSize() instead of
HeapObjectHeader::size()

HeapObjectHeader::size() is a fast version of HeapObjectHeader::payloadSize()
which works only
for headers in NormalHeapPages and FreeLists. LargeObjectPages must use
HeapObjectHeader::payloadSize() instead.

BUG=581138
==========

to

==========
Oilpan: LargeObjectPage should use HeapObjectHeader::payloadSize() instead of
HeapObjectHeader::size()

HeapObjectHeader::size() is a fast version of HeapObjectHeader::payloadSize()
which works only
for headers in NormalHeapPages and FreeLists. LargeObjectPages must use
HeapObjectHeader::payloadSize() instead.

BUG=581138

Committed: https://crrev.com/7e718004bcef5606f63211456a16cde149206525
Cr-Commit-Position: refs/heads/master@{#371483}
==========

[commit-bot: I haz the power, 2016-01-26 09:49:58]

Patchset 2 (id:??) landed as
https://crrev.com/7e718004bcef5606f63211456a16cde149206525
Cr-Commit-Position: refs/heads/master@{#371483}