Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: build/android/pylib/local/device/local_device_test_run.py

Issue 1636953002: [Android] Revise host_forwarder exception type & failure handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/devil/android/forwarder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/local/device/local_device_test_run.py
diff --git a/build/android/pylib/local/device/local_device_test_run.py b/build/android/pylib/local/device/local_device_test_run.py
index 2a93c68144cb7890b6440fd91a66d1b62c03808a..7387bb9a5baaffa9e61f4a7f88f84c19711fb4d7 100644
--- a/build/android/pylib/local/device/local_device_test_run.py
+++ b/build/android/pylib/local/device/local_device_test_run.py
@@ -6,6 +6,7 @@ import fnmatch
import functools
import logging
+from devil import base_error
from devil.android import device_errors
from pylib import valgrind_tools
from pylib.base import base_test_result
@@ -38,12 +39,13 @@ def handle_shard_failures_with(on_failure):
def wrapper(dev, *args, **kwargs):
try:
return f(dev, *args, **kwargs)
- except device_errors.CommandFailedError:
- logging.exception('Shard failed: %s(%s)', f.__name__, str(dev))
except device_errors.CommandTimeoutError:
logging.exception('Shard timed out: %s(%s)', f.__name__, str(dev))
except device_errors.DeviceUnreachableError:
logging.exception('Shard died: %s(%s)', f.__name__, str(dev))
+ except base_error.BaseError:
+ logging.exception('Shard failed: %s(%s)', f.__name__,
+ str(dev))
if on_failure:
on_failure(dev, f.__name__)
return None
« no previous file with comments | « build/android/devil/android/forwarder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698