Adding --disable-plugins-discovery command line switch to not load third-party plugins from common …

chrome/browser/browser_process_impl.h

Index: chrome/browser/browser_process_impl.h
===================================================================
--- chrome/browser/browser_process_impl.h	(revision 204507)
+++ chrome/browser/browser_process_impl.h	(working copy)
@@ -248,6 +248,9 @@
   // Sequenced task runner for local state related I/O tasks.
   const scoped_refptr<base::SequencedTaskRunner> local_state_task_runner_;
 
+  // Command line of the current process.
+  const CommandLine& command_line_;

[sky, 2013/06/07 17:22:51]

I get worried about lifetime when objects keep references like this. Is there a
reason you can't look up the CommandLine as necessary when you need it?

[seva, 2013/06/07 19:02:36]

I really have no educated opinion here, I'm not very familiar with this code. I
simply noticed there's a constructor parameter (I assumed there's a good reason
for that), and that command line actually is passed there, and that constructor
ignores that passed value. And that in one place command gets looked up, and I
would need to add another lookup. And I thought that's not perfectly clean, so I
did this change. Manual testing showed that it works.

I trust you making a decision whether this change is to the better. Let me know
and I will revert (and look up command line where I need it).

[sky, 2013/06/07 19:48:56]

I'm not sure why we pass in the CommandLine here either. Maybe Joi knows?

[seva, 2013/06/11 03:02:32]

Done.
Now browser_process_impl.h is completely reverted and browser_process_impl.cc
changes minimally.

Patch sets 5 and 7 are applying this change (sorry for the extra patch).

Patch set 6 is a sync to
https://commondatastorage.googleapis.com/chromium-browser-continuous/Linux/LA...

Once it looks good to all reviewers, Bernhard, may I ask you to commit this?

+
   // Ensures that the observers of plugin/print disable/enable state
   // notifications are properly added and removed.
   PrefChangeRegistrar pref_change_registrar_;