Adding --disable-plugins-discovery command line switch to not load third-party plugins from common …

chrome/browser/browser_process_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // When each service is created, we set a flag indicating this. At this point,
 // the service initialization could fail or succeed. This allows us to remember
 // if we tried to create a service, and not try creating it over and over if
 // the creation failed.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
@@ skipping 230 matching lines @@
   // Download status updates (like a changing application icon on dock/taskbar)
   // are global per-application. DownloadStatusUpdater does no work in the ctor
   // so we don't have to worry about lazy initialization.
   scoped_ptr<DownloadStatusUpdater> download_status_updater_;
 
   scoped_refptr<DownloadRequestLimiter> download_request_limiter_;
 
   // Sequenced task runner for local state related I/O tasks.
   const scoped_refptr<base::SequencedTaskRunner> local_state_task_runner_;
 
+  // Command line of the current process.
+  const CommandLine& command_line_;

[Bernhard Bauer, 2013/06/06 08:28:50]

Why do you need this as a member variable?

[seva, 2013/06/06 22:11:25]

This saves two CommandLine::ForCurrentProcess() calls and keeps things a bit
cleaner, more testable (BrowserProcessImpl constructor parameter "command_line"
is now used) and easier extensible (command_line is available in case it's
needed for other checks in the future, which seems likely), to my taste.

One CommandLine::ForCurrentProcess() call I removed from browser_process_impl.cc
line 902 and the other I would have to add there for my
HasSwitch(switches::kDisablePluginsDiscovery) check.

Though if you think this has issues (or too unrelated to the intention of the
patch) I'm totally open to reverting this part and just making another
CommandLine::ForCurrentProcess() call in browser_process_impl.cc.

[Bernhard Bauer, 2013/06/07 10:33:43]

No, I think it's fine. I was going to say that this isn't tested very
extensively anyway (and if it was, it's not much more difficult to override the
current command line temporarily), but I didn't see that it already gets a
command line as a construction parameter. In that case it definitely makes sense
to keep it around, to make sure we always use the same instance.

+
   // Ensures that the observers of plugin/print disable/enable state
   // notifications are properly added and removed.
   PrefChangeRegistrar pref_change_registrar_;
 
   // Lives here so can safely log events on shutdown.
   scoped_ptr<ChromeNetLog> net_log_;
 
   // Ordered before resource_dispatcher_host_delegate_ due to destruction
   // ordering.
   scoped_ptr<prerender::PrerenderTracker> prerender_tracker_;
@@ skipping 37 matching lines @@
 
 #if defined(ENABLE_WEBRTC)
   // Lazily initialized.
   scoped_ptr<WebRtcLogUploader> webrtc_log_uploader_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
 };
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_