third_party/WebKit/LayoutTests/editing/pasteboard/paste-webkit-editable-content-changed-crash.html - Issue 1636883003: Perform Spellcheck Requesting before Dispatching Events

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/pasteboard/paste-webkit-editable-content-changed-crash.html

Issue 1636883003: Perform Spellcheck Requesting before Dispatching Events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test case Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2
	yosin_UTC9 2016/01/27 06:02:38 nit: We don't need to have an extra blank line. nit: We don't need to have an extra blank line. Xiaocheng 2016/01/27 07:20:37 Done. Show quoted text On 2016/01/27 at 06:02:38, Yosi_UTC9 wrote: > nit: We don't need to have an extra blank line. Done.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5
	yosin_UTC9 2016/01/27 06:02:38 nit: We don't need to have an extra blank line. nit: We don't need to have an extra blank line. Xiaocheng 2016/01/27 07:20:37 Done. Show quoted text On 2016/01/27 at 06:02:38, Yosi_UTC9 wrote: > nit: We don't need to have an extra blank line. Done.
	6 <div id="src">

	7 <div>Some text.</div>

	8 <div>Some other text.</div>

	9 </div>

	10
	yosin_UTC9 2016/01/27 06:02:38 nit: We don't need to have an extra blank line. nit: We don't need to have an extra blank line. Xiaocheng 2016/01/27 07:20:37 Done. Show quoted text On 2016/01/27 at 06:02:38, Yosi_UTC9 wrote: > nit: We don't need to have an extra blank line. Done.
	11 <div contenteditable="true" id="dest">

	12 </div>

	13
	yosin_UTC9 2016/01/27 06:02:38 nit: We don't need to have an extra blank line. nit: We don't need to have an extra blank line. Xiaocheng 2016/01/27 07:20:37 Done. Show quoted text On 2016/01/27 at 06:02:38, Yosi_UTC9 wrote: > nit: We don't need to have an extra blank line. Done.
	14 <script>

	15 // A repro of crbug.com/580950, which crashes in debug build.

	16 document.body.onload = function() {

	17 var src = document.getElementById('src');

	18 var dest = document.getElementById('dest');

	19 var sel = window.getSelection();

	20 dest.addEventListener('webkitEditableContentChanged', function() { dest.inne rHTML='' });
	yosin_UTC9 2016/01/27 06:02:38 nit: Should be multiple lines. nit: Need spaces ar nit: Should be multiple lines. nit: Need spaces around \|=\| How about below? ES6-ish dest.addEventListener('webkitEditableContentChanged', () => dest.innerHTML = ''); Xiaocheng 2016/01/27 07:20:37 Done. Show quoted text On 2016/01/27 at 06:02:38, Yosi_UTC9 wrote: > nit: Should be multiple lines. > nit: Need spaces around \|=\| > > How about below? ES6-ish > dest.addEventListener('webkitEditableContentChanged', () => dest.innerHTML = ''); Done.
	21

	22 test(function() {

	23 sel.setBaseAndExtent(src, 0, src, src.childNodes.length);

	24 document.execCommand('copy');

	25 dest.focus();

	26 document.execCommand('paste');

	27

	28 assert_equals(dest.innerHTML, '');

	29 }, 'A pasting that fires a webkitEditableContentChanged event should not cra sh.');

	30

	31 src.style.display = "none";
	yosin_UTC9 2016/01/27 06:02:38 Add <div id="log"></div> instead of hide output. Add <div id="log"></div> instead of hide output. Xiaocheng 2016/01/27 07:20:37 Ah I didn't know this. Done. Show quoted text On 2016/01/27 at 06:02:38, Yosi_UTC9 wrote: > Add <div id="log"></div> instead of hide output. Ah I didn't know this. Done.
	32 dest.style.display = "none";

	33 }

	34 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/Editor.h » ('j') | third_party/WebKit/Source/core/editing/Editor.h » ('J')