Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: common/prpc/doc.go

Issue 1636873006: server/prpc: updated server according to protocol (Closed) Base URL: https://github.com/luci/luci-go@master
Patch Set: Respond to nits, escape externally-supplied strings when passed to format parameters. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « common/prpc/client.go ('k') | server/prpc/auth.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/prpc/doc.go
diff --git a/common/prpc/doc.go b/common/prpc/doc.go
index 9e2e5c01a8cb32c7d26617e9e0b349495d6c5ec3..9ffe61c47cf2e5373570055840cbe37ff6177bbc 100644
--- a/common/prpc/doc.go
+++ b/common/prpc/doc.go
@@ -31,7 +31,7 @@
// This section describes the pRPC protocol. It is based on HTTP 1.x and employs
// gRPC codes.
//
-// A pRPC server MUST handle HTTP requests at `/prpc/{service}/{method}` path,
+// A pRPC server MUST handle HTTP POST requests at `/prpc/{service}/{method}`,
// decode an input message from an HTTP request,
// call the service method implementation and
// encode the returned output message or error to the HTTP response.
@@ -87,7 +87,4 @@
//
// If a service/method is not found, the server MUST respond with Unimplemented
// gRPC code and SHOULD specify HTTP 501 status.
-//
-// If HTTP method is not POST, the server MUST respond with Unimplemented
-// gRPC code and SHOULD specify HTTP 405 status.
package prpc
« no previous file with comments | « common/prpc/client.go ('k') | server/prpc/auth.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698