third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: constants: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp ('K') | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/Source/wtf/PartitionAllocTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index ff330cdf7300e65f08184913904f6fa42c02805b..8290f432b2e66175bb0a6805e02215c38c1997ed 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -521,7 +521,7 @@ TEST_F(WebViewTest, SetBaseBackgroundColor)

EXPECT_EQ(kTransparent, frame->view()->baseBackgroundColor());

frame->view()->dispose();

- Color kTransparentRed(100, 0, 0, 0);

+ const Color kTransparentRed(100, 0, 0, 0);

frame->createView(IntSize(1024, 768), kTransparentRed, true);

EXPECT_EQ(kTransparentRed, frame->view()->baseBackgroundColor());

frame->view()->dispose();

@@ -2101,8 +2101,8 @@ TEST_F(WebViewTest, DispatchesFocusBlurOnViewToggle)

TEST_F(WebViewTest, SmartClipData)

{

- static const char* kExpectedClipText = "\nPrice 10,000,000won";

- static const char* kExpectedClipHtml =

+ static const char kExpectedClipText[] = "\nPrice 10,000,000won";

+ static const char kExpectedClipHtml[] =

"<div id=\"div4\" style=\"padding: 10px; margin: 10px; border: 2px "

"solid skyblue; float: left; width: 190px; height: 30px; "

"color: rgb(0, 0, 0); font-family: myahem; font-size: 8px; font-style: "