Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: src/gpu/GrGpu.h

Issue 1636873002: There is an unused rowBytes parameter being passed along. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Accidentally left in test code. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/GrContext.cpp ('k') | src/gpu/GrGpu.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef GrGpu_DEFINED 8 #ifndef GrGpu_DEFINED
9 #define GrGpu_DEFINED 9 #define GrGpu_DEFINED
10 10
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 order to compensate for swizzling that will occur when drawing. */ 213 order to compensate for swizzling that will occur when drawing. */
214 GrPixelConfig fWriteConfig; 214 GrPixelConfig fWriteConfig;
215 }; 215 };
216 216
217 /** 217 /**
218 * Used to negotiate whether and how an intermediate surface should be used to write pixels to 218 * Used to negotiate whether and how an intermediate surface should be used to write pixels to
219 * a GrSurface. If this returns false then GrGpu could not deduce an interme diate draw 219 * a GrSurface. If this returns false then GrGpu could not deduce an interme diate draw
220 * that would allow a successful transfer of the src pixels to the dst. The passed width, 220 * that would allow a successful transfer of the src pixels to the dst. The passed width,
221 * height, and rowBytes, must be non-zero and already reflect clipping to th e dst bounds. 221 * height, and rowBytes, must be non-zero and already reflect clipping to th e dst bounds.
222 */ 222 */
223 bool getWritePixelsInfo(GrSurface* dstSurface, int width, int height, size_t rowBytes, 223 bool getWritePixelsInfo(GrSurface* dstSurface, int width, int height,
224 GrPixelConfig srcConfig, DrawPreference*, WritePixel TempDrawInfo*); 224 GrPixelConfig srcConfig, DrawPreference*, WritePixel TempDrawInfo*);
225 225
226 /** 226 /**
227 * Reads a rectangle of pixels from a render target. 227 * Reads a rectangle of pixels from a render target.
228 * 228 *
229 * @param surface The surface to read from 229 * @param surface The surface to read from
230 * @param left left edge of the rectangle to read (inclusive) 230 * @param left left edge of the rectangle to read (inclusive)
231 * @param top top edge of the rectangle to read (inclusive) 231 * @param top top edge of the rectangle to read (inclusive)
232 * @param width width of rectangle to read in pixels. 232 * @param width width of rectangle to read in pixels.
233 * @param height height of rectangle to read in pixels. 233 * @param height height of rectangle to read in pixels.
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 525
526 // overridden by backend-specific derived class to perform the draw call. 526 // overridden by backend-specific derived class to perform the draw call.
527 virtual void onDraw(const DrawArgs&, const GrNonInstancedVertices&) = 0; 527 virtual void onDraw(const DrawArgs&, const GrNonInstancedVertices&) = 0;
528 528
529 virtual bool onMakeCopyForTextureParams(GrTexture* texture, const GrTextureP arams&, 529 virtual bool onMakeCopyForTextureParams(GrTexture* texture, const GrTextureP arams&,
530 GrTextureProducer::CopyParams*) cons t { return false; } 530 GrTextureProducer::CopyParams*) cons t { return false; }
531 531
532 virtual bool onGetReadPixelsInfo(GrSurface* srcSurface, int readWidth, int r eadHeight, 532 virtual bool onGetReadPixelsInfo(GrSurface* srcSurface, int readWidth, int r eadHeight,
533 size_t rowBytes, GrPixelConfig readConfig, DrawPreference*, 533 size_t rowBytes, GrPixelConfig readConfig, DrawPreference*,
534 ReadPixelTempDrawInfo*) = 0; 534 ReadPixelTempDrawInfo*) = 0;
535 virtual bool onGetWritePixelsInfo(GrSurface* dstSurface, int width, int heig ht, size_t rowBytes, 535 virtual bool onGetWritePixelsInfo(GrSurface* dstSurface, int width, int heig ht,
536 GrPixelConfig srcConfig, DrawPreference*, 536 GrPixelConfig srcConfig, DrawPreference*,
537 WritePixelTempDrawInfo*) = 0; 537 WritePixelTempDrawInfo*) = 0;
538 538
539 // overridden by backend-specific derived class to perform the surface read 539 // overridden by backend-specific derived class to perform the surface read
540 virtual bool onReadPixels(GrSurface*, 540 virtual bool onReadPixels(GrSurface*,
541 int left, int top, 541 int left, int top,
542 int width, int height, 542 int width, int height,
543 GrPixelConfig, 543 GrPixelConfig,
544 void* buffer, 544 void* buffer,
545 size_t rowBytes) = 0; 545 size_t rowBytes) = 0;
(...skipping 28 matching lines...) Expand all
574 ResetTimestamp fResetTi mestamp; 574 ResetTimestamp fResetTi mestamp;
575 uint32_t fResetBi ts; 575 uint32_t fResetBi ts;
576 // The context owns us, not vice-versa, so this ptr is not ref'ed by Gpu. 576 // The context owns us, not vice-versa, so this ptr is not ref'ed by Gpu.
577 GrContext* fContext ; 577 GrContext* fContext ;
578 578
579 friend class GrPathRendering; 579 friend class GrPathRendering;
580 typedef SkRefCnt INHERITED; 580 typedef SkRefCnt INHERITED;
581 }; 581 };
582 582
583 #endif 583 #endif
OLDNEW
« no previous file with comments | « src/gpu/GrContext.cpp ('k') | src/gpu/GrGpu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698