Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Unified Diff: content/renderer/web_ui_extension.h

Issue 163683004: Implement WebUI extension via gin instead of v8::Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/web_ui_extension.h
diff --git a/content/renderer/web_ui_extension.h b/content/renderer/web_ui_extension.h
index 07d7f11f6f56622e3ec146716a09a2050c2e67dd..82d65cd5ffd9fb41ed9a703b1d1ad71fc1d97604 100644
--- a/content/renderer/web_ui_extension.h
+++ b/content/renderer/web_ui_extension.h
@@ -5,21 +5,28 @@
#ifndef CONTENT_RENDERER_WEBUI_EXTENSION_H_
#define CONTENT_RENDERER_WEBUI_EXTENSION_H_
+#include <string>
+
#include "base/basictypes.h"
-namespace v8 {
-class Extension;
+namespace blink {
+class WebFrame;
+}
+
+namespace gin {
+class Arguments;
}
namespace content {
class WebUIExtension {
public:
- // Returns the v8::Extension object handling WebUI bindings. Caller takes
- // ownership of returned object.
- static v8::Extension* Get();
+ static void Install(blink::WebFrame* frame);
private:
+ static void Send(gin::Arguments* args);
+ static std::string GetVariableValue(const std::string& name);
+
DISALLOW_IMPLICIT_CONSTRUCTORS(WebUIExtension);
};

Powered by Google App Engine
This is Rietveld 408576698