Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2351)

Unified Diff: content/renderer/render_view_impl.cc

Issue 163683004: Implement WebUI extension via gin instead of v8::Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/web_ui_extension.h » ('j') | content/renderer/web_ui_extension.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index ef64a94a8d5cf2e4035cbdb22bda5ee8618cb9be..aa1b1f9ccf9e7616c226df4e1fa0fc64e146225b 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -3294,6 +3294,9 @@ void RenderViewImpl::didClearWindowObject(WebFrame* frame, int world_id) {
if (world_id)
return;
+ if (enabled_bindings_& BINDINGS_POLICY_WEB_UI)
+ WebUIExtension::Install(frame);
+
if (enabled_bindings_ & BINDINGS_POLICY_DOM_AUTOMATION)
DomAutomationController::Install(this, frame);
@@ -4333,8 +4336,6 @@ void RenderViewImpl::OnAllowBindings(int enabled_bindings_flags) {
!(enabled_bindings_ & BINDINGS_POLICY_WEB_UI)) {
// WebUI uses <dialog> which is not yet enabled by default in Chrome.
WebRuntimeFeatures::enableDialogElement(true);
-
- RenderThread::Get()->RegisterExtension(WebUIExtension::Get());
new WebUIExtensionData(this);
}
« no previous file with comments | « no previous file | content/renderer/web_ui_extension.h » ('j') | content/renderer/web_ui_extension.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698