The sweeper thread should not write the page flags. Added a sweeping complete phase, where the main…

The sweeper thread should not write the page flags. Added a sweeping complete phase, where the main thread writes the given page flags.

BUG=
R=jarin@chromium.org, jochen@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19377

[jochen (gone - plz use gerrit), 2014-02-13 14:57:44]

lgtm

[Jarin, 2014-02-14 09:04:13]

Almost lgtm.

https://codereview.chromium.org/163683003/diff/30001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/163683003/diff/30001/src/spaces.h#newcode467
src/spaces.h:467: PARALLEL_SWEEPING_COMPLETE,
Is not PARALLEL_SWEEPING_COMPLETE more like "in progress"?

https://codereview.chromium.org/163683003/diff/30001/src/spaces.h#newcode472
src/spaces.h:472: return static_cast<ParallelSweepingState>(parallel_sweeping_);
This should be NoBarrier_Load

[Hannes Payer (out of office), 2014-02-14 12:29:16]

https://codereview.chromium.org/163683003/diff/30001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/163683003/diff/30001/src/spaces.h#newcode467
src/spaces.h:467: PARALLEL_SWEEPING_COMPLETE,
On 2014/02/14 09:04:13, jarin wrote:
> Is not PARALLEL_SWEEPING_COMPLETE more like "in progress"?

Done.

https://codereview.chromium.org/163683003/diff/30001/src/spaces.h#newcode472
src/spaces.h:472: return static_cast<ParallelSweepingState>(parallel_sweeping_);
On 2014/02/14 09:04:13, jarin wrote:
> This should be NoBarrier_Load

Ups, I accidentally removed this one.
Done.

[Hannes Payer (out of office), 2014-02-14 12:33:42]

Committed patchset #3 manually as r19377 (presubmit successful).