Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1636633002: Ship ImageBitmap and createImageBitmap (Closed)

Created:
4 years, 11 months ago by xidachen
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship ImageBitmap and createImageBitmap Now that we have 3 LGTMs for ImageBitmap and createImageBitmap to ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/jRzvehX9U1U/discussion, let's ship it and expose it to larger audience! This CL removes the Runtime flag in ImageBitmapFactories.idl and updates some global interface layout tests results. BUG=249384 Committed: https://crrev.com/aa3e16a6a6cdec7d99a1741ebad75618909ccca7 Cr-Commit-Position: refs/heads/master@{#371340}

Patch Set 1 #

Patch Set 2 : update a layout test result #

Messages

Total messages: 10 (3 generated)
xidachen
PTAL.
4 years, 11 months ago (2016-01-25 20:48:42 UTC) #2
Rick Byers
LGTM
4 years, 11 months ago (2016-01-25 21:26:18 UTC) #3
jbroman
lgtm
4 years, 11 months ago (2016-01-25 21:29:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636633002/20001
4 years, 11 months ago (2016-01-25 21:39:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 22:52:32 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/aa3e16a6a6cdec7d99a1741ebad75618909ccca7 Cr-Commit-Position: refs/heads/master@{#371340}
4 years, 11 months ago (2016-01-25 22:54:03 UTC) #9
Justin Novosad
4 years, 10 months ago (2016-02-01 22:20:27 UTC) #10
Message was sent while issue was closed.
w00t!

Powered by Google App Engine
This is Rietveld 408576698