[CacheStorage] Check quota before put operations

[CacheStorage] Check quota before put operations

BUG=410201
Committed: https://crrev.com/1201730346ea451a292d905cb1138e958a2eb847
Cr-Commit-Position: refs/heads/master@{#371785}

[jkarlin, 2016-01-25 19:52:10]

jkarlin@chromium.org changed reviewers:
+ isherman@chromium.org, michaeln@chromium.org

[jkarlin, 2016-01-25 19:52:11]

michaeln@: PTAL at everything
isherman@: PTAL at histograms.xml

Thanks!

[Ilya Sherman, 2016-01-25 21:28:37]

histograms.xml lgtm

[michaeln, 2016-01-26 00:16:08]

lgtm

https://codereview.chromium.org/1636613002/diff/20001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_cache.cc (right):

https://codereview.chromium.org/1636613002/diff/20001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_cache.cc:281: int64_t
available_bytes;
could use = 0 here instead of adding the the initializer list

https://codereview.chromium.org/1636613002/diff/20001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_manager_unittest.cc (right):

https://codereview.chromium.org/1636613002/diff/20001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_manager_unittest.cc:85: MemoryOnly()
/* is incognito */, path,
not sure you really need the |path| local? temp_dir_.path() is empty in the
memonly case, you're already relying on that below on line 92.

[jkarlin, 2016-01-26 12:08:35]

Thanks!

https://codereview.chromium.org/1636613002/diff/20001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_cache.cc (right):

https://codereview.chromium.org/1636613002/diff/20001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_cache.cc:281: int64_t
available_bytes;
On 2016/01/26 00:16:08, michaeln wrote:
> could use = 0 here instead of adding the the initializer list

Done.

https://codereview.chromium.org/1636613002/diff/20001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_manager_unittest.cc (right):

https://codereview.chromium.org/1636613002/diff/20001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_manager_unittest.cc:85: MemoryOnly()
/* is incognito */, path,
On 2016/01/26 00:16:08, michaeln wrote:
> not sure you really need the |path| local? temp_dir_.path() is empty in the
> memonly case, you're already relying on that below on line 92.

Done. Also in cache_storage_cache_unittest.cc

[jkarlin, 2016-01-26 13:20:40]

Patchset #4 (id:60001) has been deleted

[jkarlin, 2016-01-27 13:23:28]

Patchset #4 (id:80001) has been deleted

[jkarlin, 2016-01-27 13:23:37]

Patchset #6 (id:140001) has been deleted

[jkarlin, 2016-01-27 13:23:43]

Patchset #5 (id:120001) has been deleted

[jkarlin, 2016-01-27 13:23:47]

Patchset #4 (id:100001) has been deleted

[jkarlin, 2016-01-27 14:09:18]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-01-27 14:09:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1636613002/#ps160001
(title: "Set quota per origin and fix order of operations error")

[commit-bot: I haz the power, 2016-01-27 14:09:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636613002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636613002/160001

[commit-bot: I haz the power, 2016-01-27 14:53:28]

Committed patchset #4 (id:160001)

[commit-bot: I haz the power, 2016-01-27 14:54:56]

Description was changed from

==========
[CacheStorage] Check quota before put operations

BUG=410201
==========

to

==========
[CacheStorage] Check quota before put operations

BUG=410201

Committed: https://crrev.com/1201730346ea451a292d905cb1138e958a2eb847
Cr-Commit-Position: refs/heads/master@{#371785}
==========

[commit-bot: I haz the power, 2016-01-27 14:54:57]

Patchset 4 (id:??) landed as
https://crrev.com/1201730346ea451a292d905cb1138e958a2eb847
Cr-Commit-Position: refs/heads/master@{#371785}