Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1636593002: Adding <keygen> Content Setting (Android UI) (Closed)

Created:
4 years, 11 months ago by davidben
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Adding <keygen> Content Setting (Android UI) This adds Android UI to allow the user to change the Content Setting to block/allow keygen usage on a per-site basis. To trigger the exception, we also create a Content Exception on any site that uses a <keygen> element. BUG=514767 Review URL: https://codereview.chromium.org/1432573002 Cr-Commit-Position: refs/heads/master@{#370416} (cherry picked from commit 34a7682cd49f8fdfb6a0f715a6118076f9ad8224) Committed: https://chromium.googlesource.com/chromium/src/+/797002194be4592ededdc0e3c627a1b6eee70326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -7 lines) Patch
M chrome/android/java/res/xml/single_website_preferences.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java View 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/preferences/website/KeygenInfo.java View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java View 12 chunks +35 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java View 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java View 3 chunks +31 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java View 4 chunks +71 lines, -0 lines 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 2 chunks +39 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
davidben
4 years, 11 months ago (2016-01-25 18:34:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
797002194be4592ededdc0e3c627a1b6eee70326.

Powered by Google App Engine
This is Rietveld 408576698