Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1636583003: Allow methods to be named ‘factory’ (Closed)

Created:
4 years, 11 months ago by hausner
Modified:
4 years, 11 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow methods to be named ‘factory’ Because it’s the law. BUG=25489 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/4ca841772589c193138a18ad807adc66e43cae21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/vm/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/method_name_test.dart View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 11 months ago (2016-01-25 21:36:58 UTC) #3
regis
lgtm
4 years, 11 months ago (2016-01-25 21:41:52 UTC) #4
hausner
4 years, 11 months ago (2016-01-25 21:46:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ca841772589c193138a18ad807adc66e43cae21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698