Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1636583002: ipc: remove unused variable from CreateClientUnixDomainSocket() function (Closed)

Created:
4 years, 10 months ago by tfarina
Modified:
4 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: remove unused variable from CreateClientUnixDomainSocket() function |socket_dir| variable is not unused for anything in CreateClientUnixDomainSocket() function, so this patch removes it. While at it also pass socket_path.value() directly instead of storing it in a temporary variable. BUG=None TEST=ipc_tests R=cpu@chromium.org Committed: https://crrev.com/4b0ab87c4e09e68131a8c8a75c7fe75c60470f32 Cr-Commit-Position: refs/heads/master@{#371369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M ipc/unix_domain_socket_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/unix_domain_socket_util.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
Hi Carlos, could you review this to me? While reviewing some unix socket code, I ...
4 years, 10 months ago (2016-01-25 18:31:27 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
4 years, 10 months ago (2016-01-25 22:34:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636583002/1
4 years, 10 months ago (2016-01-25 22:47:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-26 00:16:45 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 00:20:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b0ab87c4e09e68131a8c8a75c7fe75c60470f32
Cr-Commit-Position: refs/heads/master@{#371369}

Powered by Google App Engine
This is Rietveld 408576698