chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java - Issue 1636573004: Dont cache activity for external navigation handling

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Issue 1636573004: Dont cache activity for external navigation handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

index 56d5d0af490d5311e0cc05c61564795cbfcbeb34..4c62d68bff5b795c4c07b75e834595a0bc6fcd0d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

@@ -2012,7 +2012,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

public void testExternalNavigationWithUserGesture() {

final ExternalNavigationHandler externalNavHandler =

- new ExternalNavigationHandler(getActivity());

+ new ExternalNavigationHandler(getActivity().getActivityTab());

final NavigationParams navigationParams = new NavigationParams(

"intent://test/#Intent;scheme=test;package=com.chrome.test;end", "",

false /* isPost */, true /* hasUserGesture */, PageTransition.LINK,

@@ -2038,7 +2038,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

public void testRedirectedExternalNavigationWithUserGesture() {

final ExternalNavigationHandler externalNavHandler =

- new ExternalNavigationHandler(getActivity());

+ new ExternalNavigationHandler(getActivity().getActivityTab());

final NavigationParams initialNavigationParams = new NavigationParams("http://test.com", "",

false /* isPost */, true /* hasUserGesture */, PageTransition.LINK,

@@ -2072,7 +2072,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

public void testExternalNavigationWithoutUserGesture() {

final ExternalNavigationHandler externalNavHandler =

- new ExternalNavigationHandler(getActivity());

+ new ExternalNavigationHandler(getActivity().getActivityTab());

final NavigationParams navigationParams = new NavigationParams(

"intent://test/#Intent;scheme=test;package=com.chrome.test;end", "",

false /* isPost */, false /* hasUserGesture */, PageTransition.LINK,