Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1636533003: Remove dead code: ShellViewsDelegateAura (Closed)

Created:
4 years, 11 months ago by Evan Stade
Modified:
4 years, 11 months ago
Reviewers:
Peter Beverloo, sadrul
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code: ShellViewsDelegateAura BUG=none Committed: https://crrev.com/eba065b0a6fd04a472ddd10b99c22443989a0820 Cr-Commit-Position: refs/heads/master@{#371547}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M content/shell/browser/shell_views.cc View 1 2 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636533003/1
4 years, 11 months ago (2016-01-26 01:50:27 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/94268)
4 years, 11 months ago (2016-01-26 02:13:27 UTC) #4
Evan Stade
4 years, 11 months ago (2016-01-26 18:19:52 UTC) #6
sadrul
lgtm
4 years, 11 months ago (2016-01-26 18:24:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636533003/20001
4 years, 11 months ago (2016-01-26 18:37:25 UTC) #9
Peter Beverloo
//content/shell rs lgtm
4 years, 11 months ago (2016-01-26 18:43:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 18:49:54 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eba065b0a6fd04a472ddd10b99c22443989a0820 Cr-Commit-Position: refs/heads/master@{#371547}
4 years, 11 months ago (2016-01-26 18:51:17 UTC) #13
Evan Stade
4 years, 11 months ago (2016-01-26 18:55:38 UTC) #14
Message was sent while issue was closed. 
On 2016/01/26 18:43:39, Peter Beverloo wrote:
> //content/shell rs lgtm

thanks

Powered by Google App Engine
This is Rietveld 408576698