Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 1636513003: Remove the code that prevents task blocking if not expecting frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/renderer/renderer_scheduler_impl.h" 5 #include "components/scheduler/renderer/renderer_scheduler_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 2264 matching lines...) Expand 10 before | Expand all | Expand 10 after
2275 ForceUpdatePolicyAndGetCurrentUseCase()); 2275 ForceUpdatePolicyAndGetCurrentUseCase());
2276 EXPECT_TRUE(HaveSeenABeginMainframe()); 2276 EXPECT_TRUE(HaveSeenABeginMainframe());
2277 EXPECT_FALSE(LoadingTasksSeemExpensive()); 2277 EXPECT_FALSE(LoadingTasksSeemExpensive());
2278 EXPECT_TRUE(TimerTasksSeemExpensive()); 2278 EXPECT_TRUE(TimerTasksSeemExpensive());
2279 EXPECT_TRUE(TouchStartExpectedSoon()); 2279 EXPECT_TRUE(TouchStartExpectedSoon());
2280 EXPECT_THAT(run_order, testing::ElementsAre(std::string("T1"), 2280 EXPECT_THAT(run_order, testing::ElementsAre(std::string("T1"),
2281 std::string("D1"))); 2281 std::string("D1")));
2282 } 2282 }
2283 2283
2284 TEST_F(RendererSchedulerImplTest, 2284 TEST_F(RendererSchedulerImplTest,
2285 ExpensiveTimerTaskNotBlocked_IfBeginMainFrameNotExpectedSoon) { 2285 ExpensiveTimerTaskBlocked_EvenIfBeginMainFrameNotExpectedSoon) {
2286 std::vector<std::string> run_order; 2286 std::vector<std::string> run_order;
2287 2287
2288 scheduler_->SetHasVisibleRenderWidgetWithTouchHandler(true); 2288 scheduler_->SetHasVisibleRenderWidgetWithTouchHandler(true);
2289 DoMainFrame(); 2289 DoMainFrame();
2290 SimulateExpensiveTasks(timer_task_runner_); 2290 SimulateExpensiveTasks(timer_task_runner_);
2291 ForceTouchStartToBeExpectedSoon(); 2291 ForceTouchStartToBeExpectedSoon();
2292 scheduler_->BeginFrameNotExpectedSoon(); 2292 scheduler_->BeginFrameNotExpectedSoon();
2293 2293
2294 PostTestTasks(&run_order, "T1 D1"); 2294 PostTestTasks(&run_order, "T1 D1");
2295 RunUntilIdle(); 2295 RunUntilIdle();
2296 2296
2297 EXPECT_EQ(UseCase::NONE, ForceUpdatePolicyAndGetCurrentUseCase()); 2297 EXPECT_EQ(UseCase::NONE, ForceUpdatePolicyAndGetCurrentUseCase());
2298 EXPECT_TRUE(HaveSeenABeginMainframe()); 2298 EXPECT_TRUE(HaveSeenABeginMainframe());
2299 EXPECT_FALSE(LoadingTasksSeemExpensive()); 2299 EXPECT_FALSE(LoadingTasksSeemExpensive());
2300 EXPECT_FALSE(TimerTasksSeemExpensive()); 2300 EXPECT_TRUE(TimerTasksSeemExpensive());
2301 EXPECT_TRUE(TouchStartExpectedSoon()); 2301 EXPECT_TRUE(TouchStartExpectedSoon());
2302 EXPECT_THAT(run_order, 2302 EXPECT_THAT(run_order, testing::ElementsAre(std::string("D1")));
2303 testing::ElementsAre(std::string("T1"), std::string("D1")));
2304 } 2303 }
2305 2304
2306 TEST_F(RendererSchedulerImplTest, 2305 TEST_F(RendererSchedulerImplTest,
2307 ExpensiveLoadingTasksNotBlockedIfNavigationExpected) { 2306 ExpensiveLoadingTasksNotBlockedIfNavigationExpected) {
2308 std::vector<std::string> run_order; 2307 std::vector<std::string> run_order;
2309 2308
2310 DoMainFrame(); 2309 DoMainFrame();
2311 scheduler_->SetHasVisibleRenderWidgetWithTouchHandler(true); 2310 scheduler_->SetHasVisibleRenderWidgetWithTouchHandler(true);
2312 SimulateExpensiveTasks(loading_task_runner_); 2311 SimulateExpensiveTasks(loading_task_runner_);
2313 ForceTouchStartToBeExpectedSoon(); 2312 ForceTouchStartToBeExpectedSoon();
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
2762 2761
2763 EXPECT_EQ(UseCase::SYNCHRONIZED_GESTURE, 2762 EXPECT_EQ(UseCase::SYNCHRONIZED_GESTURE,
2764 ForceUpdatePolicyAndGetCurrentUseCase()); 2763 ForceUpdatePolicyAndGetCurrentUseCase());
2765 2764
2766 EXPECT_TRUE(TimerTasksSeemExpensive()); 2765 EXPECT_TRUE(TimerTasksSeemExpensive());
2767 EXPECT_TRUE(TouchStartExpectedSoon()); 2766 EXPECT_TRUE(TouchStartExpectedSoon());
2768 EXPECT_FALSE(scheduler_->TimerTaskRunner()->IsQueueEnabled()); 2767 EXPECT_FALSE(scheduler_->TimerTaskRunner()->IsQueueEnabled());
2769 } 2768 }
2770 2769
2771 } // namespace scheduler 2770 } // namespace scheduler
OLDNEW
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698