Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1636503002: Work around vs2013sp2-3 bug in skstd::unique_ptr. (Closed)

Created:
4 years, 11 months ago by bungeman-skia
Modified:
4 years, 11 months ago
Reviewers:
lsalzman1, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Work around vs2013sp2-3 bug in skstd::unique_ptr. When compiling skstd::unique_ptr::compressed_base with the vc++ in some intermediate service pack versions of Visual Studio 2013 the compiler will crash with an internal compiler error. In the interest of reducing headaches, work around this issue in skstd::unique_ptr until std::unique_ptr can be used. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/1fce5584cfd7c9cc36388b9d250f03d56ee9b254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M include/private/SkUniquePtr.h View 4 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636503002/1
4 years, 11 months ago (2016-01-25 16:24:08 UTC) #4
bungeman-skia
I have not personally tested that this works around the compiler bug mentioned in the ...
4 years, 11 months ago (2016-01-25 16:34:08 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 16:37:01 UTC) #8
lsalzman1
lgtm
4 years, 11 months ago (2016-01-25 17:57:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636503002/1
4 years, 11 months ago (2016-01-25 20:59:49 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 21:00:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1fce5584cfd7c9cc36388b9d250f03d56ee9b254

Powered by Google App Engine
This is Rietveld 408576698