content/public/browser/browser_context.h - Issue 1636483002: Update the PushEvent to have a nullable PushMessageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_context.h

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/common/service_worker/service_worker_messages.h ('k') | content/public/common/push_event_payload.h » ('j') | content/public/common/push_event_payload.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/browser_context.h

diff --git a/content/public/browser/browser_context.h b/content/public/browser/browser_context.h

index 9897d4d3f88378573101265e93d70a6eec228eda..7096fcd0d427760ae303a4a182d1d75dec2a7a4d 100644

--- a/content/public/browser/browser_context.h

+++ b/content/public/browser/browser_context.h

@@ -14,6 +14,7 @@

#include "base/supports_user_data.h"

#include "content/common/content_export.h"

#include "content/public/browser/zoom_level_delegate.h"

+#include "content/public/common/push_event_payload.h"

#include "content/public/common/push_messaging_status.h"

class GURL;

@@ -108,7 +109,7 @@ class CONTENT_EXPORT BrowserContext : public base::SupportsUserData {

BrowserContext* browser_context,

const GURL& origin,

int64_t service_worker_registration_id,

- const std::string& data,

+ const content::PushEventPayload& payload,

Peter Beverloo 2016/01/26 12:35:18 s/content:://

harkness 2016/01/26 14:49:20 Done.

const base::Callback<void(PushDeliveryStatus)>& callback);

static void NotifyWillBeDestroyed(BrowserContext* browser_context);