Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments and include Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 8b55a3c8728875bfe172af6501fdccdf83f8017d..dc8f4d2fa205508fddd2a205226affcc63e42576 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -32,6 +32,7 @@
#include "content/common/mojo/service_registry_impl.h"
#include "content/common/service_worker/embedded_worker_messages.h"
#include "content/common/service_worker/service_worker_messages.h"
+#include "content/public/common/push_event_payload.h"
#include "content/public/common/referrer.h"
#include "content/public/renderer/content_renderer_client.h"
#include "content/public/renderer/document_state.h"
@@ -760,10 +761,14 @@ void ServiceWorkerContextClient::OnNotificationClickEvent(
}
void ServiceWorkerContextClient::OnPushEvent(int request_id,
- const std::string& data) {
+ const PushEventPayload& payload) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerContextClient::OnPushEvent");
- proxy_->dispatchPushEvent(request_id, blink::WebString::fromUTF8(data));
+ // Only set data to be a valid string if the payload had decrypted data.
+ blink::WebString data;
+ if (!payload.is_null)
+ data.assign(blink::WebString::fromUTF8(payload.data));
+ proxy_->dispatchPushEvent(request_id, data);
}
void ServiceWorkerContextClient::OnGeofencingEvent(
« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.h ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698